[all-commits] [llvm/llvm-project] 33cbda: Improve error logging when xcrun fails to execute ...

[Adrian Prantl via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 33cbda4cacb87103bbb5f4f9f2368bbb442132f4
      https://github.com/llvm/llvm-project/commit/33cbda4cacb87103bbb5f4f9f2368bbb442132f4
  Author: Adrian Prantl <aprantl at apple.com>
  Date:   2022-12-01 (Thu, 01 Dec 2022)

  Changed paths:
    M lldb/include/lldb/Host/HostInfoBase.h
    M lldb/include/lldb/Host/macosx/HostInfoMacOSX.h
    M lldb/source/Core/Module.cpp
    M lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm
    M lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
    M lldb/source/Plugins/Platform/MacOSX/PlatformMacOSX.cpp
    M lldb/unittests/Host/CMakeLists.txt
    M lldb/unittests/Host/HostInfoTest.cpp

  Log Message:
  -----------
  Improve error logging when xcrun fails to execute successfully

Because Host::RunShellCommand runs commands through $SHELL there is an
opportunity for this to fail spectacularly on systems that use custom
shells with odd behaviors. This patch makes these situations easier to
debug by at least logging the result of the failed xcrun invocation.

It also doesn't run xcrun through a shell any more.

rdar://102389438

Differential Revision: https://reviews.llvm.org/D138060