[all-commits] [llvm/llvm-project] 6de939: [runtimes] Name stripped install targets consistently

[Shoaib Meenai via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6de939dbe7519f21ba774199e91f7fba9fd55cef
      https://github.com/llvm/llvm-project/commit/6de939dbe7519f21ba774199e91f7fba9fd55cef
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2022-11-30 (Wed, 30 Nov 2022)

  Changed paths:
    M llvm/runtimes/CMakeLists.txt
    M runtimes/CMakeLists.txt

  Log Message:
  -----------
  [runtimes] Name stripped install targets consistently

We were previously naming sub-component stripped install targets as
`install-${component}-stripped-${triple}`, whereas everywhere else names
them `install-${component}-${triple}-stripped`. This inconsistency would
cause issues when LLVM_RUNTIME_DISTRIBUTION_COMPONENTS contained a
sub-component (which I'm addding support for next).

Reviewed By: phosek, #libc, #libc_abi, ldionne

Differential Revision: https://reviews.llvm.org/D138965


  Commit: a323e515eee85121c6b85f08eef5acc427d22f83
      https://github.com/llvm/llvm-project/commit/a323e515eee85121c6b85f08eef5acc427d22f83
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2022-11-30 (Wed, 30 Nov 2022)

  Changed paths:
    M llvm/runtimes/CMakeLists.txt

  Log Message:
  -----------
  [runtimes] Support sub-components in LLVM_RUNTIME_DISTRIBUTION_COMPONENTS

Right now, sub-components are only accounted for when the runtime has
been configured and the main LLVM configure is rerun after that. We can
make use of LLVM_RUNTIME_DISTRIBUTION_COMPONENTS to make sub-component
targets available from the start, but that currently clashes with the
sub-component target generation once they are picked up. Make sure we
don't create duplicate targets; an analogous check already exists in
runtime_default_target.

Reviewed By: phosek

Differential Revision: https://reviews.llvm.org/D138966


  Commit: 8947f26b8822a3dde6c0fe192a789de880d4afcb
      https://github.com/llvm/llvm-project/commit/8947f26b8822a3dde6c0fe192a789de880d4afcb
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2022-11-30 (Wed, 30 Nov 2022)

  Changed paths:
    M llvm/runtimes/CMakeLists.txt

  Log Message:
  -----------
  [runtimes] Create check- targets for LLVM_RUNTIME_DISTRIBUTION_COMPONENTS

The sub-component check targets won't be automatically created until the
runtime configurations have run (and the main LLVM configure has rerun
afterwards). Work around this by creating check- targets for components
in LLVM_RUNTIME_DISTRIBUTION_COMPONENTS as well (and making sure they
get the proper test dependencies).

Reviewed By: phosek

Differential Revision: https://reviews.llvm.org/D138967


  Commit: a57d91ef6bff1de199740f1741e2bfdca0e86bdd
      https://github.com/llvm/llvm-project/commit/a57d91ef6bff1de199740f1741e2bfdca0e86bdd
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2022-11-30 (Wed, 30 Nov 2022)

  Changed paths:
    M llvm/runtimes/CMakeLists.txt

  Log Message:
  -----------
  [runtimes] Add check-profile dependencies to runtimes

check-profile needs llvm-cov and llvm-profdata.

Reviewed By: phosek

Differential Revision: https://reviews.llvm.org/D138968


  Commit: 442c13f9ff8a8c6739d649c5a68e065f2a727480
      https://github.com/llvm/llvm-project/commit/442c13f9ff8a8c6739d649c5a68e065f2a727480
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2022-11-30 (Wed, 30 Nov 2022)

  Changed paths:
    M compiler-rt/test/profile/CMakeLists.txt

  Log Message:
  -----------
  [compiler-rt] Fix check-profile dependencies

It relies on InstrProfData.inc being in the compiler resource directory.

Reviewed By: ellis

Differential Revision: https://reviews.llvm.org/D138969


Compare: https://github.com/llvm/llvm-project/compare/5eacdcff0653...442c13f9ff8a