[all-commits] [llvm/llvm-project] 855fe3: AddressSanitizer: Convert tests to opaque pointers

Matt Arsenault via All-commits all-commits at lists.llvm.org
Sun Nov 27 17:11:10 PST 2022 

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 855fe35064674c4601ea9c659a015cacdcec9f63
      https://github.com/llvm/llvm-project/commit/855fe35064674c4601ea9c659a015cacdcec9f63
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2022-11-27 (Sun, 27 Nov 2022)

  Changed paths:
    M llvm/test/Instrumentation/AddressSanitizer/AMDGPU/asan_do_not_instrument_lds.ll
    M llvm/test/Instrumentation/AddressSanitizer/AMDGPU/asan_do_not_instrument_scratch.ll
    M llvm/test/Instrumentation/AddressSanitizer/AMDGPU/asan_instrument_constant_address_space.ll
    M llvm/test/Instrumentation/AddressSanitizer/AMDGPU/asan_instrument_generic_address_space.ll
    M llvm/test/Instrumentation/AddressSanitizer/AMDGPU/asan_instrument_global_address_space.ll
    M llvm/test/Instrumentation/AddressSanitizer/AMDGPU/global_metadata_addrspacecasts.ll
    M llvm/test/Instrumentation/AddressSanitizer/AMDGPU/instrument-stack.ll
    M llvm/test/Instrumentation/AddressSanitizer/X86/asm_cpuid.ll
    M llvm/test/Instrumentation/AddressSanitizer/X86/asm_more_registers_than_available.ll
    M llvm/test/Instrumentation/AddressSanitizer/X86/bug_11395.ll
    M llvm/test/Instrumentation/AddressSanitizer/alloca-offset-lifetime.ll
    M llvm/test/Instrumentation/AddressSanitizer/asan-detect-invalid-pointer-pair.ll
    M llvm/test/Instrumentation/AddressSanitizer/asan-disable-sanitizer-instrumentation.ll
    M llvm/test/Instrumentation/AddressSanitizer/asan-masked-load-store.ll
    M llvm/test/Instrumentation/AddressSanitizer/asan-optimize-callbacks.ll
    M llvm/test/Instrumentation/AddressSanitizer/asan-stack-safety.ll
    M llvm/test/Instrumentation/AddressSanitizer/asan-vs-gvn.ll
    M llvm/test/Instrumentation/AddressSanitizer/asan_address_space_attr.ll
    M llvm/test/Instrumentation/AddressSanitizer/basic-msvc64.ll
    M llvm/test/Instrumentation/AddressSanitizer/basic.ll
    M llvm/test/Instrumentation/AddressSanitizer/byref-args.ll
    M llvm/test/Instrumentation/AddressSanitizer/byval-args.ll
    M llvm/test/Instrumentation/AddressSanitizer/debug-info-alloca.ll
    M llvm/test/Instrumentation/AddressSanitizer/debug_info.ll
    M llvm/test/Instrumentation/AddressSanitizer/debug_info_noninstrumented_alloca.ll
    M llvm/test/Instrumentation/AddressSanitizer/debug_info_noninstrumented_alloca2.ll
    M llvm/test/Instrumentation/AddressSanitizer/do-not-instrument-globals-linux.ll
    M llvm/test/Instrumentation/AddressSanitizer/do-not-instrument-internal-globals.ll
    M llvm/test/Instrumentation/AddressSanitizer/do-not-instrument-netbsd-link_set.ll
    M llvm/test/Instrumentation/AddressSanitizer/do-not-instrument-promotable-allocas.ll
    M llvm/test/Instrumentation/AddressSanitizer/do-not-instrument-sanitizers.ll
    M llvm/test/Instrumentation/AddressSanitizer/do-not-touch-comdat-global.ll
    M llvm/test/Instrumentation/AddressSanitizer/dynamic-shadow-darwin.ll
    M llvm/test/Instrumentation/AddressSanitizer/experiment-call.ll
    M llvm/test/Instrumentation/AddressSanitizer/experiment.ll
    M llvm/test/Instrumentation/AddressSanitizer/fake-stack.ll
    M llvm/test/Instrumentation/AddressSanitizer/force-dynamic-shadow.ll
    M llvm/test/Instrumentation/AddressSanitizer/freebsd.ll
    M llvm/test/Instrumentation/AddressSanitizer/global_addrspace.ll
    M llvm/test/Instrumentation/AddressSanitizer/global_lto_merge.ll
    M llvm/test/Instrumentation/AddressSanitizer/global_metadata_array.ll
    M llvm/test/Instrumentation/AddressSanitizer/global_metadata_bitcasts.ll
    M llvm/test/Instrumentation/AddressSanitizer/global_metadata_windows.ll
    M llvm/test/Instrumentation/AddressSanitizer/hoist-argument-init-insts.ll
    M llvm/test/Instrumentation/AddressSanitizer/instrument-dynamic-allocas.ll
    M llvm/test/Instrumentation/AddressSanitizer/instrument-no-return.ll
    M llvm/test/Instrumentation/AddressSanitizer/instrument-section-invalid-c-ident.ll
    M llvm/test/Instrumentation/AddressSanitizer/instrument-stack.ll
    M llvm/test/Instrumentation/AddressSanitizer/instrument_global.ll
    M llvm/test/Instrumentation/AddressSanitizer/instrument_initializer_metadata.ll
    M llvm/test/Instrumentation/AddressSanitizer/instrument_load_then_store.ll
    M llvm/test/Instrumentation/AddressSanitizer/instrumentation-with-call-threshold.ll
    M llvm/test/Instrumentation/AddressSanitizer/keep_going.ll
    M llvm/test/Instrumentation/AddressSanitizer/lifetime-throw.ll
    M llvm/test/Instrumentation/AddressSanitizer/lifetime-uar-uas.ll
    M llvm/test/Instrumentation/AddressSanitizer/lifetime.ll
    M llvm/test/Instrumentation/AddressSanitizer/localescape.ll
    M llvm/test/Instrumentation/AddressSanitizer/mem-intrinsics.ll
    M llvm/test/Instrumentation/AddressSanitizer/module-flags.ll
    M llvm/test/Instrumentation/AddressSanitizer/musttail.ll
    M llvm/test/Instrumentation/AddressSanitizer/ps4.ll
    M llvm/test/Instrumentation/AddressSanitizer/scale-offset.ll
    M llvm/test/Instrumentation/AddressSanitizer/stack-poisoning-and-lifetime-be.ll
    M llvm/test/Instrumentation/AddressSanitizer/stack-poisoning-and-lifetime.ll
    M llvm/test/Instrumentation/AddressSanitizer/stack-poisoning-byval-args.ll
    M llvm/test/Instrumentation/AddressSanitizer/stack-poisoning.ll
    M llvm/test/Instrumentation/AddressSanitizer/stack_dynamic_alloca.ll
    M llvm/test/Instrumentation/AddressSanitizer/stack_layout.ll
    M llvm/test/Instrumentation/AddressSanitizer/str-nobuiltin.ll
    M llvm/test/Instrumentation/AddressSanitizer/test64.ll
    M llvm/test/Instrumentation/AddressSanitizer/twice.ll
    M llvm/test/Instrumentation/AddressSanitizer/ubsan.ll
    M llvm/test/Instrumentation/AddressSanitizer/win-sorted-sections.ll
    M llvm/test/Instrumentation/AddressSanitizer/win-string-literal.ll
    M llvm/test/Instrumentation/AddressSanitizer/with-ifunc.ll

  Log Message:
  -----------
  AddressSanitizer: Convert tests to opaque pointers

Needed some manual fixes:
  AMDGPU/asan_instrument_generic_address_space.ll
  dynamic-shadow-darwin.ll
  lifetime.ll
  stack-poisoning-byval-args.ll
  global_metadata_windows.ll
  asan-masked-load-store.ll
  stack-poisoning-and-lifetime.ll
  stack-poisoning-and-lifetime-be.ll

This included some of the worst opaquify breakages I've seen. The
tests were dependent on 0 indexed GEPs, and had check lines directly
checking pointee types.


  Commit: f7114520558decb820e12b00976ce81460e7156d
      https://github.com/llvm/llvm-project/commit/f7114520558decb820e12b00976ce81460e7156d
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2022-11-27 (Sun, 27 Nov 2022)

  Changed paths:
    M llvm/test/Instrumentation/DataFlowSanitizer/origin_cached_shadows.ll

  Log Message:
  -----------
  DataFlowSanitizer: Don't use anonymous values in test

This interferes with test updates.


  Commit: 66c3444f4cc5c1f70ec33e7806f8236a39b6adc2
      https://github.com/llvm/llvm-project/commit/66c3444f4cc5c1f70ec33e7806f8236a39b6adc2
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2022-11-27 (Sun, 27 Nov 2022)

  Changed paths:
    M llvm/test/Instrumentation/DataFlowSanitizer/abilist.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/abilist_aggregate.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/array.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/atomics.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/basic.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/call.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/callback.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/custom_fun_callback_attributes.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/custom_fun_varargs_attributes.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/debug-nonzero-labels.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/dont_combine_offset_labels_on_gep.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/extern_weak.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/force_zero.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/ignore_persnality_routine.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/load.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/lookup_table.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/memset.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/musttailcall.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/origin_abilist.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/origin_load.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/origin_mem_intrinsic.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/origin_other_ops.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/origin_store.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/origin_store_threshold.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/origin_track_load.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/prefix-rename.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/store.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/struct.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/union.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/unordered_atomic_mem_intrins.ll
    M llvm/test/Instrumentation/DataFlowSanitizer/vector.ll

  Log Message:
  -----------
  DataFlowSanitizer: Convert most tests to opaque pointers

This was pain every step of the way; there's still one to go.


Compare: https://github.com/llvm/llvm-project/compare/026e797367d9...66c3444f4cc5

More information about the All-commits mailing list