[all-commits] [llvm/llvm-project] 907bae: Revert "Make -fsanitize=scudo use scudo_standalone...

Hans via All-commits all-commits at lists.llvm.org
Wed Nov 23 07:13:35 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 907baeec49bfbe9e76498634a9418e1dc6c973d9
      https://github.com/llvm/llvm-project/commit/907baeec49bfbe9e76498634a9418e1dc6c973d9
  Author: Hans Wennborg <hans at chromium.org>
  Date:   2022-11-23 (Wed, 23 Nov 2022)

  Changed paths:
    M clang/lib/Driver/ToolChains/CommonArgs.cpp
    M clang/test/Driver/fuchsia.c
    M clang/test/Driver/sanitizer-ld.c
    M compiler-rt/cmake/config-ix.cmake
    M compiler-rt/lib/CMakeLists.txt
    M compiler-rt/test/CMakeLists.txt
    A compiler-rt/test/scudo/CMakeLists.txt
    M llvm/docs/GwpAsan.rst

  Log Message:
  -----------
  Revert "Make -fsanitize=scudo use scudo_standalone. Delete check-scudo."

It broke the build, see comments on code review.

> Leaves the implementation and tests files in-place for right now, but
> deletes the ability to build the old sanitizer-common based scudo. This
> has been on life-support for a long time, and the newer scudo_standalone
> is much better supported and maintained.
>
> Also patches up some GWP-ASan wording, primarily related to the fact
> that -fsanitize=scudo now is scudo_standalone, and therefore the way to
> reference the GWP-ASan options through the environment variable has
> changed.
>
> Future follow-up patches will delete the original scudo, and migrate all
> its tests over to be part of the scudo_standalone test suite.
>
> Reviewed By: vitalybuka
>
> Differential Revision: https://reviews.llvm.org/D138157

This reverts commit ab1a5991fe765d71c0f3262f25726d6b4d66a545.




More information about the All-commits mailing list