[all-commits] [llvm/llvm-project] 64f5fe: [ASTContext][NFC] Remove getTargetAddressSpace(Qua...

Alexander Richardson via All-commits all-commits at lists.llvm.org
Wed Nov 23 01:26:35 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 64f5fedb59e82a79c0c669c3d6591ca9eadb82fb
      https://github.com/llvm/llvm-project/commit/64f5fedb59e82a79c0c669c3d6591ca9eadb82fb
  Author: Alex Richardson <alexrichardson at google.com>
  Date:   2022-11-23 (Wed, 23 Nov 2022)

  Changed paths:
    M clang/include/clang/AST/ASTContext.h
    M clang/lib/AST/ASTContext.cpp
    M clang/lib/CodeGen/CodeGenTypes.cpp

  Log Message:
  -----------
  [ASTContext][NFC] Remove getTargetAddressSpace(Qualifiers Q)

This simply calls getTargetAddressSpace(Q.getAddressSpace()) and there
are only two callers, so adjust those caller instead.


  Commit: 88218d5c5282c7b13bee667a0ce975a540aed74c
      https://github.com/llvm/llvm-project/commit/88218d5c5282c7b13bee667a0ce975a540aed74c
  Author: Alex Richardson <alexrichardson at google.com>
  Date:   2022-11-23 (Wed, 23 Nov 2022)

  Changed paths:
    M llvm/include/llvm/CodeGen/SelectionDAGNodes.h
    M llvm/include/llvm/Target/TargetSelectionDAG.td
    M llvm/lib/Target/AMDGPU/R600ISelLowering.cpp
    M llvm/lib/Target/AMDGPU/SIInstrInfo.td
    M llvm/lib/Target/ARM/ARMInstrMVE.td
    M llvm/lib/Target/ARM/ARMInstrNEON.td
    M llvm/lib/Target/ARM/ARMInstrVFP.td
    M llvm/lib/Target/M68k/M68kInstrInfo.td
    M llvm/lib/Target/Mips/MipsISelDAGToDAG.cpp
    M llvm/lib/Target/PowerPC/PPCInstrInfo.td
    M llvm/lib/Target/X86/X86InstrFragmentsSIMD.td
    M llvm/lib/Target/X86/X86InstrInfo.td
    A llvm/test/CodeGen/Mips/load-max-alignment.ll

  Log Message:
  -----------
  [SelectionDAG] Remove deprecated MemSDNode->getAlignment()

I noticed a an assertion error when building MIPS code that loaded from
NULL. Loading from NULL ends up being a load with maximum alignment, and
due to integer truncation the value maximum was interpreted as 0 and the
assertion in MipsDAGToDAGISel::Select() failed. This previously happened
to work, but the maximum alignment was increased in
df84c1fe78130a86445d57563dea742e1b85156a, so it no longer fits into a 32
bit integer.
Instead of just fixing the one MIPS case, this patch removes all uses of
the deprecated getAlignment() call and replaces them with getAlign().

Differential Revision: https://reviews.llvm.org/D138420


  Commit: 4559864897500193d2812cea7b66dc8daba0b836
      https://github.com/llvm/llvm-project/commit/4559864897500193d2812cea7b66dc8daba0b836
  Author: Alex Richardson <alexrichardson at google.com>
  Date:   2022-11-23 (Wed, 23 Nov 2022)

  Changed paths:
    M libcxx/docs/ReleaseNotes.rst
    M libcxx/include/__locale
    M libcxx/include/regex

  Log Message:
  -----------
  [libc++] Fix __regex_word value when using newlib/picolibc

The ctype mask for newlib/picolibc is fully saturated, so __regex_word
has to overlap with one of the values. This commit uses the same workaround
as bionic did (uint16_t for char_class_type inside regex_traits). It
should be possible to have libc++ provide the default rune table instead,
but that will require a new mechanism to detect newlib inside __config
since the header defining the newlib/picolibc macros has not been included
yet inside __config. Doing it this way also avoids duplicating the ctype
table for newlib, reducing the global data size.

Differential Revision: https://reviews.llvm.org/D138195


Compare: https://github.com/llvm/llvm-project/compare/3fe89be80159...455986489750


More information about the All-commits mailing list