[all-commits] [llvm/llvm-project] 4e18d5: [SROA] `isVectorPromotionViable()`: pointer-ness i...

Roman Lebedev via All-commits all-commits at lists.llvm.org
Tue Nov 22 13:23:40 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4e18d51ac55d05e8900110cc0ae3d64cdd953b81
      https://github.com/llvm/llvm-project/commit/4e18d51ac55d05e8900110cc0ae3d64cdd953b81
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-11-23 (Wed, 23 Nov 2022)

  Changed paths:
    M llvm/lib/Transforms/Scalar/SROA.cpp
    M llvm/test/Transforms/SROA/vector-conversion.ll

  Log Message:
  -----------
  [SROA] `isVectorPromotionViable()`: pointer-ness is sticky

As it has been established previously by precedent,
if we see a pointer type, then that is the type we must use.
Essentially, we don't want to introduce `inttoptr`'s.


  Commit: 529eafd9beff233ba8debfc73e0b5c04cac36835
      https://github.com/llvm/llvm-project/commit/529eafd9beff233ba8debfc73e0b5c04cac36835
  Author: Roman Lebedev <lebedev.ri at gmail.com>
  Date:   2022-11-23 (Wed, 23 Nov 2022)

  Changed paths:
    M llvm/lib/Transforms/Scalar/SROA.cpp
    M llvm/test/Transforms/SROA/vector-promotion.ll

  Log Message:
  -----------
  [SROA] `isVectorPromotionViable()`: integer-ify non-pointer non-common types

This rectifies a FIXME that dates all the way back
to 2014 about not doing so due to the backend issues.

Presumably sufficient amount of time has passes
and all the known issues have been addressed,
or at least we will find out of there are some left...


Compare: https://github.com/llvm/llvm-project/compare/bc0c89d3d853...529eafd9beff


More information about the All-commits mailing list