[all-commits] [llvm/llvm-project] ae7a3e: [test][lldb-vscode] Un-realpath coreFile test.

[Jordan Rupprecht via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ae7a3e1c1d3ed7125c2436b9fd50512f7548acd7
      https://github.com/llvm/llvm-project/commit/ae7a3e1c1d3ed7125c2436b9fd50512f7548acd7
  Author: Jordan Rupprecht <rupprecht at google.com>
  Date:   2022-11-21 (Mon, 21 Nov 2022)

  Changed paths:
    M lldb/test/API/tools/lldb-vscode/coreFile/TestVSCode_coreFile.py

  Log Message:
  -----------
  [test][lldb-vscode] Un-realpath coreFile test.

TestVSCode_coreFile looks for an exe/core file in the same directory as the test. It first calls `realpath`, but I don't think it's necessary. Using `realpath` prevents this test from working when run as part of a build system that uses content-addressed-storage, i.e. all the files might all be symlinks in the same directory pointing to files in different directories elsewhere. If some amount of normalization is needed, maybe `os.path.normpath()` would be useful, although I wouldn't see why that's needed either.

(This is a fairly trivial patch, but I'm mailing it to see if there is a reason we need to keep `realpath`, and if so, if there's some other workaround we can do).

Differential Revision: https://reviews.llvm.org/D138345