[all-commits] [llvm/llvm-project] 3598c2: [mlir][linalg] Change linalg.broadcast `dimensions...

Oleg Shyshkov via All-commits all-commits at lists.llvm.org
Mon Nov 21 04:17:07 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3598c24983be90a582cdafb7864e302193c340f4
      https://github.com/llvm/llvm-project/commit/3598c24983be90a582cdafb7864e302193c340f4
  Author: Oleg Shyshkov <shyshkov at google.com>
  Date:   2022-11-21 (Mon, 21 Nov 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
    M mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
    M mlir/test/Dialect/Linalg/invalid.mlir
    M mlir/test/Dialect/Linalg/one-shot-bufferize.mlir
    M mlir/test/Dialect/Linalg/roundtrip.mlir
    M mlir/test/Interfaces/TilingInterface/lower-to-loops-using-interface.mlir

  Log Message:
  -----------
  [mlir][linalg] Change linalg.broadcast `dimensions` attribute to represent added dimensions.

Original [RFC](discourse.llvm.org/t/rfc-primitive-ops-add-broadcastop-to-linalg/66313) defined `dimensions` as a map from input to init, but a discussion in reviews.llvm.org/D138291 concluded that it's more natural for `dimensions` to represent added dims. Also this way is more consistent with `linalg.reduce`.

Differential Revision: https://reviews.llvm.org/D138408




More information about the All-commits mailing list