[all-commits] [llvm/llvm-project] eb3f78: [clang-tblgen][NFC] renames Diagnostic.Text to Dia...

Christopher Di Bella via All-commits all-commits at lists.llvm.org
Sun Nov 20 19:56:49 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: eb3f7880a272b818940e2bd2510ae04b0e32873f
      https://github.com/llvm/llvm-project/commit/eb3f7880a272b818940e2bd2510ae04b0e32873f
  Author: Christopher Di Bella <cjdb at google.com>
  Date:   2022-11-21 (Mon, 21 Nov 2022)

  Changed paths:
    M clang/include/clang/Basic/Diagnostic.td
    M clang/include/clang/Basic/DiagnosticCommonKinds.td
    M clang/include/clang/Basic/DiagnosticFrontendKinds.td
    M clang/include/clang/Basic/DiagnosticLexKinds.td
    M clang/include/clang/Basic/DiagnosticSemaKinds.td
    M clang/test/TableGen/DiagnosticBase.inc
    M clang/utils/TableGen/ClangDiagnosticsEmitter.cpp

  Log Message:
  -----------
  [clang-tblgen][NFC] renames Diagnostic.Text to Diagnostic.Summary

The [Improving Clang's Diagnostics RFC][1] identifies eight broad fields
for Clang to surface, two of which are text-based. Since the current
diagnostics more closely map to the diagnostic summary (or headline), we
should rename them to ensure that there's no confusion when
Diagnostic.Reason is introduced in the near future.

[1]: https://discourse.llvm.org/t/rfc-improving-clang-s-diagnostics/62584

Reviewed By: aaron.ballman, erichkeane

Differential Revision: https://reviews.llvm.org/D135820




More information about the All-commits mailing list