[all-commits] [llvm/llvm-project] 2fea65: [mlir] GreedyPatternRewriter: Reprocess modified ops

[Matthias Springer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2fea658a74196a9c9128be34c5bc306eba7a025e
      https://github.com/llvm/llvm-project/commit/2fea658a74196a9c9128be34c5bc306eba7a025e
  Author: Matthias Springer <springerm at google.com>
  Date:   2022-11-18 (Fri, 18 Nov 2022)

  Changed paths:
    M mlir/lib/Dialect/Vector/Transforms/VectorTransferSplitRewritePatterns.cpp
    M mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp
    A mlir/test/IR/greedy-pattern-rewriter-driver.mlir
    M mlir/test/lib/Dialect/Test/TestPatterns.cpp

  Log Message:
  -----------
  [mlir] GreedyPatternRewriter: Reprocess modified ops

Ops that were modifed in-place (`finalizeRootUpdate` was called) should be reprocessed by the GreedyPatternRewriter. This is currently not happening with `GreedyRewriteConfig::maxIterations = 1`.

Note: If your project goes into an infinite loop because of this change, you likely have one or multiple faulty patterns that modify the same operations in-place (`updateRootInplace`) indefinitely.

Differential Revision: https://reviews.llvm.org/D138038