[all-commits] [llvm/llvm-project] 446fc4: [mlir] Fix ordering of intermixed attribute/type a...

[River Riddle via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 446fc42d7cf2d7c3e56abf6b3267bc3956735f71
      https://github.com/llvm/llvm-project/commit/446fc42d7cf2d7c3e56abf6b3267bc3956735f71
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-11-18 (Fri, 18 Nov 2022)

  Changed paths:
    M mlir/lib/IR/AsmPrinter.cpp
    M mlir/test/IR/print-attr-type-aliases.mlir
    M mlir/test/Target/LLVMIR/Import/debug-info.ll

  Log Message:
  -----------
  [mlir] Fix ordering of intermixed attribute/type aliases

We properly order dependencies between attribute/type aliases,
but we currently always print attribute aliases separately from type
aliases. This creates problems if an attribute wants to use a type
alias during printing.

This commit refactors alias collection such that attribute/type aliases
are collected together and printed together.

Differential Revision: https://reviews.llvm.org/D138162


  Commit: d023661115e2b878f5b68a31d092ea3619a77754
      https://github.com/llvm/llvm-project/commit/d023661115e2b878f5b68a31d092ea3619a77754
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-11-18 (Fri, 18 Nov 2022)

  Changed paths:
    M mlir/include/mlir-c/IR.h
    M mlir/include/mlir/IR/OperationSupport.h
    M mlir/lib/Bindings/Python/IRCore.cpp
    M mlir/lib/CAPI/IR/IR.cpp
    M mlir/lib/IR/AsmPrinter.cpp
    M mlir/test/CAPI/ir.c

  Log Message:
  -----------
  [mlir][AsmPrinter] Allow explicitly disabling debug info

This adds an `enable` flag to OpPrintingFlags::enableDebugInfo
that allows for overriding any command line flags for debug printing,
and matches the format that we use for other `enableBlah` API.


  Commit: d473dac3d63f7b54dd29f9c3e8077267457a4254
      https://github.com/llvm/llvm-project/commit/d473dac3d63f7b54dd29f9c3e8077267457a4254
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-11-18 (Fri, 18 Nov 2022)

  Changed paths:
    M mlir/include/mlir/IR/SubElementInterfaces.h
    M mlir/lib/IR/SubElementInterfaces.cpp

  Log Message:
  -----------
  [mlir][SubElementInterfaces] Add a recursivelyReplaceElementsIn helper to AttrTypeReplacer

This somewhat improves the ergonomics when replacing recursively within
a set of IR.


Compare: https://github.com/llvm/llvm-project/compare/fcd5098a03da...d473dac3d63f