[all-commits] [llvm/llvm-project] 2c6184: [Coroutines] Handle the writes to promise alloca p...

Chuanqi Xu via All-commits all-commits at lists.llvm.org
Thu Nov 17 23:40:06 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2c61848c9dba4c26621587af3a626ae6129380fc
      https://github.com/llvm/llvm-project/commit/2c61848c9dba4c26621587af3a626ae6129380fc
  Author: Chuanqi Xu <yedeng.yd at linux.alibaba.com>
  Date:   2022-11-18 (Fri, 18 Nov 2022)

  Changed paths:
    M llvm/lib/Transforms/Coroutines/CoroFrame.cpp
    A llvm/test/Transforms/Coroutines/coro-spill-promise-02.ll

  Log Message:
  -----------
  [Coroutines] Handle the writes to promise alloca prior to
llvm.coro.begin

Previously we've taken care of the writes to allocas prior to llvm.coro.begin.
However, since the promise alloca is special so that we never handled it
before. For the long time, since the programmers can't access the
promise_type due to the c++ language specification, we still failed to
recognize the problem until a recent report:
https://github.com/llvm/llvm-project/issues/57861

And we've tested many codes that the problem gone away after we handle
the writes to the promise alloca prior to @llvm.coro.begin()
prope until a recent report:
https://github.com/llvm/llvm-project/issues/57861

And we've tested many codes that the problem gone away after we handle
the writes to the promise alloca prior to @llvm.coro.begin() properly.

Closes https://github.com/llvm/llvm-project/issues/57861




More information about the All-commits mailing list