[all-commits] [llvm/llvm-project] fe287b: [openmp] Only try to add the -mrtm flag on i386/x8...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Thu Nov 17 22:52:51 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fe287bf096c6b5fdf46b2d34590311099852abd4
      https://github.com/llvm/llvm-project/commit/fe287bf096c6b5fdf46b2d34590311099852abd4
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-11-18 (Fri, 18 Nov 2022)

  Changed paths:
    M openmp/runtime/cmake/LibompHandleFlags.cmake

  Log Message:
  -----------
  [openmp] Only try to add the -mrtm flag on i386/x86_64

Clang does accept the flag for any architecture, but prints a
warning:

    clang-16: warning: argument unused during compilation: '-mrtm' [-Wunused-command-line-argument]

This flag is documented as an x86 specific flag, so don't try to
add it for other architectures, to silence this warning.

Differential Revision: https://reviews.llvm.org/D137744


  Commit: a6440b0fc535f660334cb48ca002e2fb34f5c4b4
      https://github.com/llvm/llvm-project/commit/a6440b0fc535f660334cb48ca002e2fb34f5c4b4
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-11-18 (Fri, 18 Nov 2022)

  Changed paths:
    M openmp/runtime/test/omp_testsuite.h

  Log Message:
  -----------
  [openmp] [test] Fix warnings about printf format mismatches on Windows

This fixes warnings like this:

```
openmp/runtime/test/omp_testsuite.h:107:60: warning: format specifies type 'unsigned int' but the argument has type 'DWORD' (aka 'unsigned long') [-Wformat]
    fprintf(stderr, "CreateThread() failed: Error #%u.\n", GetLastError());
                                                   ~~      ^~~~~~~~~~~~~~
                                                   %lu
```

Differential Revision: https://reviews.llvm.org/D137747


Compare: https://github.com/llvm/llvm-project/compare/7e6dbfcd9d26...a6440b0fc535


More information about the All-commits mailing list