[all-commits] [llvm/llvm-project] fc91c7: Revert D135411 "Add generic KCFI operand bundle lo...

Fangrui Song via All-commits all-commits at lists.llvm.org
Thu Nov 17 14:45:43 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fc91c705937d7ba3b92da38f3a883dde720c41f2
      https://github.com/llvm/llvm-project/commit/fc91c705937d7ba3b92da38f3a883dde720c41f2
  Author: Fangrui Song <i at maskray.me>
  Date:   2022-11-17 (Thu, 17 Nov 2022)

  Changed paths:
    M clang/lib/CodeGen/BackendUtil.cpp
    M clang/lib/Driver/ToolChain.cpp
    M llvm/include/llvm/InitializePasses.h
    R llvm/include/llvm/Transforms/Instrumentation/KCFI.h
    M llvm/lib/Passes/PassBuilder.cpp
    M llvm/lib/Passes/PassRegistry.def
    M llvm/lib/Transforms/Instrumentation/CMakeLists.txt
    R llvm/lib/Transforms/Instrumentation/KCFI.cpp
    R llvm/test/Transforms/KCFI/kcfi-patchable-function-prefix.ll
    R llvm/test/Transforms/KCFI/kcfi-supported.ll
    R llvm/test/Transforms/KCFI/kcfi.ll
    M llvm/utils/gn/secondary/llvm/lib/Transforms/Instrumentation/BUILD.gn

  Log Message:
  -----------
  Revert D135411 "Add generic KCFI operand bundle lowering"

This reverts commit eb2a57ebc7aaad551af30462097a9e06c96db925.

llvm/include/llvm/Transforms/Instrumentation/KCFI.h including
llvm/CodeGen is a layering violation. We should use an approach where
Instrumementation/ doesn't need to include CodeGen/.
Sorry for not spotting this in the review.




More information about the All-commits mailing list