[all-commits] [llvm/llvm-project] 70dbd7: [ARM][AArch64] Use StringRef in TargetParser structs

tmatheson-arm via All-commits all-commits at lists.llvm.org
Thu Nov 17 10:44:27 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 70dbd7bb12e6af2e2c7ff3759c011cfe5bc36c11
      https://github.com/llvm/llvm-project/commit/70dbd7bb12e6af2e2c7ff3759c011cfe5bc36c11
  Author: Tomas Matheson <tomas.matheson at arm.com>
  Date:   2022-11-17 (Thu, 17 Nov 2022)

  Changed paths:
    M llvm/include/llvm/Support/AArch64TargetParser.def
    M llvm/include/llvm/Support/AArch64TargetParser.h
    M llvm/include/llvm/Support/ARMTargetParser.def
    M llvm/include/llvm/Support/ARMTargetParser.h
    M llvm/lib/Support/AArch64TargetParser.cpp
    M llvm/lib/Support/ARMTargetParser.cpp
    M llvm/unittests/Support/TargetParserTest.cpp

  Log Message:
  -----------
  [ARM][AArch64] Use StringRef in TargetParser structs

The invalid case is now represented by an empty StringRef rather than
a nullptr.

Previously ARCH_FEATURE was build from SUB_ARCH by prepending "+".
This is now reverse, so that the "+arch-feature" is now visible in
the .def, which is a bit clearer. This meant converting one StringSwitch
into a loop.

Removed getters which are now mostly unnecessary.

Removed some old FIXMEs.

Differential Revision: https://reviews.llvm.org/D138026




More information about the All-commits mailing list