[all-commits] [llvm/llvm-project] 9d8629: [mlir][sparse] Adding safe comparison functions to...

wren romano via All-commits all-commits at lists.llvm.org
Wed Nov 16 16:17:02 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9d862992d1bafc0a0d9ebe5941ddb8d3fef39b0b
      https://github.com/llvm/llvm-project/commit/9d862992d1bafc0a0d9ebe5941ddb8d3fef39b0b
  Author: wren romano <2998727+wrengr at users.noreply.github.com>
  Date:   2022-11-16 (Wed, 16 Nov 2022)

  Changed paths:
    A mlir/include/mlir/ExecutionEngine/SparseTensor/ArithmeticUtils.h
    R mlir/include/mlir/ExecutionEngine/SparseTensor/CheckedMul.h
    M mlir/include/mlir/ExecutionEngine/SparseTensor/Storage.h
    M utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

  Log Message:
  -----------
  [mlir][sparse] Adding safe comparison functions to MLIRSparseTensorRuntime.

Different platforms use different signedness for `StridedMemRefType::sizes` and `std::vector::size_type`, and this has been causing a lot of portability issues re [-Wsign-compare] warnings.  These new functions ensure that we need never worry about those signedness warnings ever again.

Also merging CheckedMul.h into ArithmeticUtils.h

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D138149




More information about the All-commits mailing list