[all-commits] [llvm/llvm-project] 0e0061: [clangd] Add heuristic for dropping snippet when c...

[Tom Praschan via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0e00611cbc2b2f27e247a58b512cb2cec0624290
      https://github.com/llvm/llvm-project/commit/0e00611cbc2b2f27e247a58b512cb2cec0624290
  Author: Tom Praschan <13141438+tom-anders at users.noreply.github.com>
  Date:   2022-11-17 (Thu, 17 Nov 2022)

  Changed paths:
    M clang-tools-extra/clangd/CodeComplete.cpp
    M clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
    M clang/include/clang/Sema/CodeCompleteConsumer.h
    M clang/lib/Sema/SemaCodeComplete.cpp
    M clang/unittests/Sema/CodeCompleteTest.cpp

  Log Message:
  -----------
  [clangd] Add heuristic for dropping snippet when completing member function pointer

This implements the 1st heuristic mentioned in https://github.com/clangd/clangd/issues/968#issuecomment-1002242704:

When completing a function that names a non-static member of a class, and we are not inside that class's scope, assume the reference will not be a call (and thus don't add the snippetSuffix)

Reviewed By: nridge

Differential Revision: https://reviews.llvm.org/D137040