[all-commits] [llvm/llvm-project] e989b8: AutoUpgrade: Fix assertion on invalid name manglin...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Wed Nov 16 11:18:16 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e989b8bb5fb36abac6e8f82809f06144dd762113
      https://github.com/llvm/llvm-project/commit/e989b8bb5fb36abac6e8f82809f06144dd762113
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2022-11-16 (Wed, 16 Nov 2022)

  Changed paths:
    M llvm/lib/IR/AutoUpgrade.cpp
    A llvm/test/Assembler/autoupgrade-invalid-name-mangling.ll

  Log Message:
  -----------
  AutoUpgrade: Fix assertion on invalid name mangling usage

This was trying to auto-upgrade a read_register call with missing type
mangling. This first would break since getCalledFunction checks the
callee type is consistent, so this would assert there. After that,
the replacement code would die on the type mismatch. Be more
defensive and let the verifier code produce an error that the IR
is broken.




More information about the All-commits mailing list