[all-commits] [llvm/llvm-project] 979274: [NFC][SelectionDAG][DebugInfo] Remove duplicate pa...

Orlando Cazalet-Hyams via All-commits all-commits at lists.llvm.org
Wed Nov 16 02:15:16 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 979274465094aac11e33901b7aa4887d9751fc55
      https://github.com/llvm/llvm-project/commit/979274465094aac11e33901b7aa4887d9751fc55
  Author: OCHyams <orlando.hyams at sony.com>
  Date:   2022-11-16 (Wed, 16 Nov 2022)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h

  Log Message:
  -----------
  [NFC][SelectionDAG][DebugInfo] Remove duplicate parameter from handleDebugValue

handleDebugValue has two DebugLoc parameters that appear to always take the
same value. Remove one of the duplicate parameters. See phabricator review for
more detail.

Reviewed By: StephenTozer

Differential Revision: https://reviews.llvm.org/D136247


  Commit: a1ac6efcb01ab8840d269056f01fb564b44c7ddc
      https://github.com/llvm/llvm-project/commit/a1ac6efcb01ab8840d269056f01fb564b44c7ddc
  Author: OCHyams <orlando.hyams at sony.com>
  Date:   2022-11-16 (Wed, 16 Nov 2022)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
    M llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h

  Log Message:
  -----------
  [NFC][SelectionDAG][DebugInfo] Refactor DanglingDebugInfo class

Hide the underlying DbgValueInst by adding methods to extract the necessary
information and by adding a raw_ostream &operator<< overload to print it.

Remove the DebugLoc field as this is always the same as the DbgValueInst's
DebugLoc (see D136247).

Reviewed By: StephenTozer

Differential Revision: https://reviews.llvm.org/D136249


Compare: https://github.com/llvm/llvm-project/compare/e08ca4bb1dfe...a1ac6efcb01a


More information about the All-commits mailing list