[all-commits] [llvm/llvm-project] cb0ffa: [lldb] Fix simple template names and template para...

[aeubanks via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cb0ffa529a0f7f907fd89587fc2ab4f6ffd57cf5
      https://github.com/llvm/llvm-project/commit/cb0ffa529a0f7f907fd89587fc2ab4f6ffd57cf5
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2022-11-15 (Tue, 15 Nov 2022)

  Changed paths:
    M lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
    M lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h
    M lldb/test/API/lang/cpp/unique-types2/TestUniqueTypes2.py
    M lldb/test/API/lang/cpp/unique-types2/main.cpp

  Log Message:
  -----------
  [lldb] Fix simple template names and template params with scope qualifiers

Followup to D134378.

With PrintingPolicy::SuppressScope, we'd also not print the scope in template params. The intention was only to skip the scope for the class because we expect template params to be fully qualified when comparing them for simple template names.

Instead, use `NamedDecl::getNameForDiagnostic` if we're dealing with a tag, which is what we actually use when emitting debug info in clang. That already has an option to suppress the scope on the base name.

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D137583