[all-commits] [llvm/llvm-project] fc367d: [mlir] Remove `Transforms/SideEffectUtils.h` and m...

[MaheshRavishankar via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fc367dfa6770fda4adc4e5de79846f22e7e4e215
      https://github.com/llvm/llvm-project/commit/fc367dfa6770fda4adc4e5de79846f22e7e4e215
  Author: Mahesh Ravishankar <ravishankarm at google.com>
  Date:   2022-11-15 (Tue, 15 Nov 2022)

  Changed paths:
    M mlir/include/mlir/Interfaces/SideEffectInterfaceBase.td
    M mlir/include/mlir/Interfaces/SideEffectInterfaces.h
    R mlir/include/mlir/Transforms/SideEffectUtils.h
    M mlir/lib/Analysis/SliceAnalysis.cpp
    M mlir/lib/Conversion/SCFToGPU/CMakeLists.txt
    M mlir/lib/Conversion/SCFToGPU/SCFToGPU.cpp
    M mlir/lib/Dialect/Affine/Analysis/AffineAnalysis.cpp
    M mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt
    M mlir/lib/Dialect/Bufferization/Transforms/Bufferize.cpp
    M mlir/lib/Dialect/Bufferization/Transforms/CMakeLists.txt
    M mlir/lib/Dialect/GPU/CMakeLists.txt
    M mlir/lib/Dialect/GPU/Transforms/AsyncRegionRewriter.cpp
    M mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp
    M mlir/lib/Dialect/SCF/Transforms/CMakeLists.txt
    M mlir/lib/Dialect/SCF/Transforms/ParallelLoopFusion.cpp
    M mlir/lib/Dialect/SCF/Utils/CMakeLists.txt
    M mlir/lib/Dialect/SCF/Utils/Utils.cpp
    M mlir/lib/Dialect/Vector/Transforms/CMakeLists.txt
    M mlir/lib/Dialect/Vector/Transforms/VectorDistribute.cpp
    M mlir/lib/Dialect/Vector/Transforms/VectorTransferOpTransforms.cpp
    M mlir/lib/Interfaces/SideEffectInterfaces.cpp
    M mlir/lib/Transforms/CMakeLists.txt
    M mlir/lib/Transforms/CSE.cpp
    M mlir/lib/Transforms/ControlFlowSink.cpp
    M mlir/lib/Transforms/Inliner.cpp
    M mlir/lib/Transforms/LoopInvariantCodeMotion.cpp
    M mlir/lib/Transforms/Utils/CMakeLists.txt
    M mlir/lib/Transforms/Utils/LoopInvariantCodeMotionUtils.cpp
    R mlir/lib/Transforms/Utils/SideEffectUtils.cpp
    M mlir/test/Dialect/SparseTensor/codegen_buffer_initialization.mlir
    M utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

  Log Message:
  -----------
  [mlir] Remove `Transforms/SideEffectUtils.h` and move the methods into `Interface/SideEffectInterfaces.h`.

The methods in `SideEffectUtils.h` (and their implementations in
`SideEffectUtils.cpp`) seem to have similar intent to methods already
existing in `SideEffectInterfaces.h`. Move the decleration (and
implementation) from `SideEffectUtils.h` (and `SideEffectUtils.cpp`)
into `SideEffectInterfaces.h` (and `SideEffectInterface.cpp`).

Also drop the `SideEffectInterface::hasNoEffect` method in favor of
`mlir::isMemoryEffectFree` which actually recurses into the operation
instead of just relying on the `hasRecursiveMemoryEffectTrait`
exclusively.

Differential Revision: https://reviews.llvm.org/D137857