[all-commits] [llvm/llvm-project] 1b829c: [gn build] Make libcxx_enable_debug_mode work bett...

[Nico Weber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1b829c3d3a8c0488f8aa553eb15c7ee658f491c9
      https://github.com/llvm/llvm-project/commit/1b829c3d3a8c0488f8aa553eb15c7ee658f491c9
  Author: Nico Weber <thakis at chromium.org>
  Date:   2022-11-15 (Tue, 15 Nov 2022)

  Changed paths:
    M llvm/utils/gn/secondary/libcxx/config.gni
    M llvm/utils/gn/secondary/libcxx/include/BUILD.gn
    M llvm/utils/gn/secondary/libcxx/src/BUILD.gn

  Log Message:
  -----------
  [gn build] Make libcxx_enable_debug_mode work better, maybe

Refer to _LIBCPP_ENABLE_DEBUG_MODE instead of the old _LIBCPP_DEBUG
in a comment, and write that to __config_site correctly too.

See 13ea1343231fa4 and the comments in https://crbug.com/1358646.

Also change the default of libcxx_enable_debug_mode to false for now.
Since we used to not write _LIBCPP_ENABLE_DEBUG_MODE, the previous
default of true had no effect (except for compiling debug.cpp and
legacy_debug_handler.cpp, which we now no longer build by default).
So this (mostly) preserves previous behavior.