[all-commits] [llvm/llvm-project] 8ad88f: Do not write a comma when varargs is the only argu...

Joshua Cao via All-commits all-commits at lists.llvm.org
Mon Nov 14 02:46:48 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8ad88f129cc489fc3076f399fd9c1bebc6e28bf1
      https://github.com/llvm/llvm-project/commit/8ad88f129cc489fc3076f399fd9c1bebc6e28bf1
  Author: Joshua Cao <cao.joshua at yahoo.com>
  Date:   2022-11-14 (Mon, 14 Nov 2022)

  Changed paths:
    M llvm/lib/IR/AsmWriter.cpp
    M llvm/test/Transforms/Inline/inline-brunch-funnel.ll

  Log Message:
  -----------
  Do not write a comma when varargs is the only argument

Fixes https://github.com/llvm/llvm-project/issues/56544

AsmWriter always writes ", ..." when a tail call has a varargs argument. This patch only writes the ", " when there is an argument before the varargs argument.

I did not write a dedicated test this for this change, but I modified an existing test that will test for a regression.

Reviewed By: avogelsgesang

Differential Revision: https://reviews.llvm.org/D137893

Signed-off-by: Adrian Vogelsgesang <avogelsgesang at salesforce.com>




More information about the All-commits mailing list