[all-commits] [llvm/llvm-project] fe0d4b: [RISCV] Add test for incorrect sext.w removal. NFC

Craig Topper via All-commits all-commits at lists.llvm.org
Sun Nov 13 17:30:56 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fe0d4ba37312cdd334790a3947cc31a7fbea974a
      https://github.com/llvm/llvm-project/commit/fe0d4ba37312cdd334790a3947cc31a7fbea974a
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2022-11-13 (Sun, 13 Nov 2022)

  Changed paths:
    M llvm/test/CodeGen/RISCV/sextw-removal.ll

  Log Message:
  -----------
  [RISCV] Add test for incorrect sext.w removal. NFC


  Commit: 03f9009cbf2a94c65692c209f091b1d63b37c991
      https://github.com/llvm/llvm-project/commit/03f9009cbf2a94c65692c209f091b1d63b37c991
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2022-11-13 (Sun, 13 Nov 2022)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVSExtWRemoval.cpp
    M llvm/test/CodeGen/RISCV/sextw-removal.ll

  Log Message:
  -----------
  [RISCV] Fix incorrect early out from isSignExtendedW in RISCVSExtWRemoval.

We can only return false to abort. If the criteria is met we need
to use continue instead. Returning true stops us from visiting all
nodes and makes the caller think it is safe to remove sext.w.


Compare: https://github.com/llvm/llvm-project/compare/16d969ca8a42...03f9009cbf2a


More information about the All-commits mailing list