[all-commits] [llvm/llvm-project] 4e0d2f: [X86] Fix sched class typo - the CVTPD2DQrr instru...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Sun Nov 13 03:13:56 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4e0d2f8e6f140573fbe527b65be99f3347b94155
      https://github.com/llvm/llvm-project/commit/4e0d2f8e6f140573fbe527b65be99f3347b94155
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2022-11-13 (Sun, 13 Nov 2022)

  Changed paths:
    M llvm/lib/Target/X86/X86ScheduleZnver1.td

  Log Message:
  -----------
  [X86] Fix sched class typo - the CVTPD2DQrr instructions were mapping to ZnWriteCVTDQ2PDr instead of ZnWriteCVTPD2DQr


  Commit: e19cb9c57fea7981c206fcbaf9807870de6001a0
      https://github.com/llvm/llvm-project/commit/e19cb9c57fea7981c206fcbaf9807870de6001a0
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2022-11-13 (Sun, 13 Nov 2022)

  Changed paths:
    M llvm/lib/Target/X86/X86ScheduleZnver1.td
    M llvm/lib/Target/X86/X86ScheduleZnver2.td
    M llvm/test/tools/llvm-mca/X86/Znver1/resources-avx1.s
    M llvm/test/tools/llvm-mca/X86/Znver1/resources-sse2.s
    M llvm/test/tools/llvm-mca/X86/Znver2/resources-avx1.s
    M llvm/test/tools/llvm-mca/X86/Znver2/resources-sse2.s

  Log Message:
  -----------
  [X86] Cleanup CVTPD2PS schedule values

The znver1/znver2 schedules for CVTPD2PS were incorrectly double pumping the xmm-load variant instead of the ymm variants (znver1 only)

Also, the xmm-load variant was incorrectly using FP03 instead of just FP3

Confirmed by the AMD SoG 17h tables, Agner + uops.info

Another step towards removing a lot of unnecessary overrides from all the x86 scheduler models - these should hopefully be convertible into regular WriteCvtPD2I classes soon.


Compare: https://github.com/llvm/llvm-project/compare/ff1ebcc5fe19...e19cb9c57fea


More information about the All-commits mailing list