[all-commits] [llvm/llvm-project] 794316: [clang-include-cleaner] make SymbolLocation a real...

Sam McCall via All-commits all-commits at lists.llvm.org
Fri Nov 11 04:43:06 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7943169273b22f61a0322cb2d38ff75845e52628
      https://github.com/llvm/llvm-project/commit/7943169273b22f61a0322cb2d38ff75845e52628
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2022-11-11 (Fri, 11 Nov 2022)

  Changed paths:
    M clang-tools-extra/include-cleaner/lib/Analysis.cpp
    M clang-tools-extra/include-cleaner/lib/AnalysisInternal.h
    M clang-tools-extra/include-cleaner/lib/CMakeLists.txt
    A clang-tools-extra/include-cleaner/lib/FindHeaders.cpp
    A clang-tools-extra/include-cleaner/lib/LocateSymbol.cpp
    M clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp
    M clang-tools-extra/include-cleaner/unittests/CMakeLists.txt
    A clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp

  Log Message:
  -----------
  [clang-include-cleaner] make SymbolLocation a real class, move FindHeaders

- replace SymbolLocation std::variant with enum-exposing version similar to
  those in types.cpp. There's no appropriate implementation file, added
  LocateSymbol.cpp in anticipation of locateDecl/locateMacro.
- FindHeaders is not part of the public Analysis interface, so should not
  be implemented/tested there (just code organization)
- rename findIncludeHeaders->findHeaders to avoid confusion with Include concept

Differential Revision: https://reviews.llvm.org/D137825




More information about the All-commits mailing list