[all-commits] [llvm/llvm-project] af6b1f: [AsmParser] Match mandatory operands following opt...

[Ivan Kosarev via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: af6b1f797f946c560f8a7b0e647f51e23d4c666f
      https://github.com/llvm/llvm-project/commit/af6b1f797f946c560f8a7b0e647f51e23d4c666f
  Author: Ivan Kosarev <ivan.kosarev at amd.com>
  Date:   2022-11-10 (Thu, 10 Nov 2022)

  Changed paths:
    M llvm/test/MC/AMDGPU/gfx10_err_pos.s
    M llvm/test/MC/AMDGPU/gfx9-asm-err.s
    M llvm/test/MC/AMDGPU/gfx9_err_pos.s
    M llvm/test/MC/AMDGPU/mubuf.s
    M llvm/test/MC/SystemZ/asm-match.s
    M llvm/test/MC/X86/x86_64-asm-match.s
    M llvm/utils/TableGen/AsmMatcherEmitter.cpp

  Log Message:
  -----------
  [AsmParser] Match mandatory operands following optional operands.

Currently, the asm parser stops matching instruction operands as soon as the first optional operand is encountered. This leads to the need for custom checks on missing mandatory operands that come after optional operands.

The patch changes the parser to always match all optional and mandatory instruction operands, thus making the custom checks unnecessary. This is particularly useful for the AMDGPU backend where we have numerous optional instruction modifiers.

Reviewed By: dp

Differential Revision: https://reviews.llvm.org/D137549