[all-commits] [llvm/llvm-project] d518ed: Handle aliasing a non-top-level command.

jimingham via All-commits all-commits at lists.llvm.org
Wed Nov 9 10:14:48 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d518ed42ae85786c371fd4578f72ab7eb286cb30
      https://github.com/llvm/llvm-project/commit/d518ed42ae85786c371fd4578f72ab7eb286cb30
  Author: Jim Ingham <jingham at apple.com>
  Date:   2022-11-09 (Wed, 09 Nov 2022)

  Changed paths:
    M lldb/include/lldb/Interpreter/CommandObject.h
    M lldb/source/Commands/CommandObjectCommands.cpp
    M lldb/test/API/commands/command/container/TestContainerCommands.py

  Log Message:
  -----------
  Handle aliasing a non-top-level command.

This didn't work previously because we had to check whether the incoming
command was an alias command, but if it wasn't we still used the result
of that lookup - which was by the command's node name.  That fails for
non-top-level commands.  In this case, the resolution is pretty simple since
we already have the node's CommandObject, so all we needed to do was turn
it into a shared pointer, for which I added enable_shared_from_this to the
CommandObject.

Differential Revision: https://reviews.llvm.org/D137662




More information about the All-commits mailing list