[all-commits] [llvm/llvm-project] 0ba039: [amdgpu][lds] Use the same isKernel predicate cons...

Jon Chesterfield via All-commits all-commits at lists.llvm.org
Wed Nov 9 08:45:32 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0ba0398517778514eb44cb7ba9bf9d4d20a856e0
      https://github.com/llvm/llvm-project/commit/0ba0398517778514eb44cb7ba9bf9d4d20a856e0
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2022-11-09 (Wed, 09 Nov 2022)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp
    M llvm/lib/Target/AMDGPU/Utils/AMDGPUMemoryUtils.cpp

  Log Message:
  -----------
  [amdgpu][lds] Use the same isKernel predicate consistently

isKernelCC != isKernel(F->getCallingConv())
There's a test case (lower-kernel-lds.ll) that explicitly skips amdgpu_ps
so this change picks the isKernel predicate that continues to skip that
calling convention.

isKernel returns true for AMDGPU_KERNEL and SPIR_KERNEL. isKernelCC also
returns true for other calling conventions.

Reviewed By: arsenm

Differential Revision: https://reviews.llvm.org/D136599




More information about the All-commits mailing list