[all-commits] [llvm/llvm-project] 405799: Fix D132221 rebase: Add flags to enable Assignment...

Orlando Cazalet-Hyams via All-commits all-commits at lists.llvm.org
Wed Nov 9 01:57:39 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 40579983555c7ed510e47bf2a0354bc1c0ec4d47
      https://github.com/llvm/llvm-project/commit/40579983555c7ed510e47bf2a0354bc1c0ec4d47
  Author: OCHyams <orlando.hyams at sony.com>
  Date:   2022-11-09 (Wed, 09 Nov 2022)

  Changed paths:
    M clang/include/clang/Driver/Options.td

  Log Message:
  -----------
  Fix D132221 rebase: Add flags to enable Assignment Tracking

The flags were not set up properly after rebasing the patch, causing bot
failures for D132226, for example:

https://lab.llvm.org/buildbot/#/builders/109/builds/50251


  Commit: 4b6b2b1a425a2eabb3a4b995bb05f4f53e313afa
      https://github.com/llvm/llvm-project/commit/4b6b2b1a425a2eabb3a4b995bb05f4f53e313afa
  Author: OCHyams <orlando.hyams at sony.com>
  Date:   2022-11-09 (Wed, 09 Nov 2022)

  Changed paths:
    M clang/lib/CodeGen/BackendUtil.cpp
    A clang/test/CodeGen/assignment-tracking/assignment-tracking.cpp
    A clang/test/CodeGen/assignment-tracking/flag.cpp
    A clang/test/CodeGen/assignment-tracking/memcpy-fragment.cpp
    A clang/test/CodeGen/assignment-tracking/nested-scope.cpp
    A clang/test/Driver/assignment-tracking-opts.c

  Log Message:
  -----------
  Reapply: [Assignment Tracking][7/*] Add assignment tracking functionality to clang

Reverted in 98fa95492f3bbd5befdeb36c88a3ac5ef2740b4e.

The Assignment Tracking debug-info feature is outlined in this RFC:

https://discourse.llvm.org/t/
rfc-assignment-tracking-a-better-way-of-specifying-variable-locations-in-ir

This patch plumbs the AssignmentTrackingPass (AKA declare-to-assign), added in
the previous patch in this set, into the optimisation pipeline from
clang. clang/test/CodeGen/assignment-tracking/assignment-tracking.cpp is the
main test for this patch.

Note: while clang (with the help of the declare-to-assign pass) can now emit
Assignment Tracking metadata, the llvm middle and back ends don't yet
understand it.

Reviewed By: jmorse

Differential Revision: https://reviews.llvm.org/D132226


Compare: https://github.com/llvm/llvm-project/compare/78f11a392301...4b6b2b1a425a


More information about the All-commits mailing list