[all-commits] [llvm/llvm-project] 7c2d31: [mlir][spirv] Don't return value when cannot fold ...

Lei Zhang via All-commits all-commits at lists.llvm.org
Mon Nov 7 16:14:07 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7c2d3153a9481793da58894dbf35d4994f3b67a4
      https://github.com/llvm/llvm-project/commit/7c2d3153a9481793da58894dbf35d4994f3b67a4
  Author: Lei Zhang <antiagainst at google.com>
  Date:   2022-11-07 (Mon, 07 Nov 2022)

  Changed paths:
    M mlir/lib/Dialect/SPIRV/IR/SPIRVCanonicalization.cpp

  Log Message:
  -----------
  [mlir][spirv] Don't return value when cannot fold spirv.bitcast

Returing a value would make the canonicalization infrastructure
think that folding succeeded so the pattern will be tried again
when invoked via, e.g., `applyPatternsAndFoldGreedily` and
eventually fail due to not converging after 10 times by default.

Reviewed By: hanchung

Differential Revision: https://reviews.llvm.org/D137598




More information about the All-commits mailing list