[all-commits] [llvm/llvm-project] afa22c: [clangd] Pass the entire tooling::CompileCommand t...

[Nathan Ridge via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: afa22c563f12f22da93b8f172d18c7991392d071
      https://github.com/llvm/llvm-project/commit/afa22c563f12f22da93b8f172d18c7991392d071
  Author: Nathan Ridge <zeratul976 at hotmail.com>
  Date:   2022-11-07 (Mon, 07 Nov 2022)

  Changed paths:
    M clang-tools-extra/clangd/ClangdLSPServer.cpp
    M clang-tools-extra/clangd/CompileCommands.cpp
    M clang-tools-extra/clangd/CompileCommands.h
    M clang-tools-extra/clangd/GlobalCompilationDatabase.cpp
    M clang-tools-extra/clangd/GlobalCompilationDatabase.h
    M clang-tools-extra/clangd/indexer/IndexerMain.cpp
    M clang-tools-extra/clangd/tool/Check.cpp
    M clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp
    M clang-tools-extra/clangd/unittests/ClangdTests.cpp
    M clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp
    M clang-tools-extra/clangd/unittests/GlobalCompilationDatabaseTests.cpp
    M clang-tools-extra/clangd/unittests/TestTU.cpp

  Log Message:
  -----------
  [clangd] Pass the entire tooling::CompileCommand to CommandMangler

This gives CommandMangler access to other fields of
tooling::CompileCommand as well, e.g. Directory.

Differential Revision: https://reviews.llvm.org/D133756


  Commit: 68e230aa29f71ed840a0ea9c0be97c8c6ead1c69
      https://github.com/llvm/llvm-project/commit/68e230aa29f71ed840a0ea9c0be97c8c6ead1c69
  Author: Nathan Ridge <zeratul976 at hotmail.com>
  Date:   2022-11-07 (Mon, 07 Nov 2022)

  Changed paths:
    M clang-tools-extra/clangd/ClangdLSPServer.cpp
    M clang-tools-extra/clangd/CompileCommands.cpp
    M clang-tools-extra/clangd/CompileCommands.h
    M clang-tools-extra/clangd/GlobalCompilationDatabase.h
    M clang-tools-extra/clangd/QueryDriverDatabase.cpp
    M clang-tools-extra/clangd/test/system-include-extractor.test
    M clang-tools-extra/clangd/tool/Check.cpp

  Log Message:
  -----------
  [clangd] Perform system include extraction inside CommandMangler

It needs to run after edits from config files are applied to
the compile command (because the config file may specify the
compiler), and before resolveDriver() runs at the end of
CommandMangler.

As part of this change, QueryDriverDatabase is renamed to
SystemIncludeExtractor and is no longer a GlobalCompilationDatabase.

Fixes https://github.com/clangd/clangd/issues/1089
Fixes https://github.com/clangd/clangd/issues/1173
Fixes https://github.com/clangd/clangd/issues/1263

Differential Revision: https://reviews.llvm.org/D133757


  Commit: 428ac8f3a0f9572fcff03c2fae62c4ae8420a0df
      https://github.com/llvm/llvm-project/commit/428ac8f3a0f9572fcff03c2fae62c4ae8420a0df
  Author: Nathan Ridge <zeratul976 at hotmail.com>
  Date:   2022-11-07 (Mon, 07 Nov 2022)

  Changed paths:
    M clang-tools-extra/clangd/CMakeLists.txt
    R clang-tools-extra/clangd/QueryDriverDatabase.cpp
    A clang-tools-extra/clangd/SystemIncludeExtractor.cpp

  Log Message:
  -----------
  [clangd] Rename QueryDriverDatabase.cpp to SystemIncludeExtractor.cpp

Differential Revision: https://reviews.llvm.org/D137401


Compare: https://github.com/llvm/llvm-project/compare/79f9f1f8e335...428ac8f3a0f9