[all-commits] [llvm/llvm-project] d25ef0: [AutoUpgrade] Fix length check for intrinsic upgrade

Nikita Popov via All-commits all-commits at lists.llvm.org
Fri Oct 21 01:53:21 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d25ef09466e4e4ca807e85360812cf9d139c4249
      https://github.com/llvm/llvm-project/commit/d25ef09466e4e4ca807e85360812cf9d139c4249
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2022-10-21 (Fri, 21 Oct 2022)

  Changed paths:
    M llvm/lib/IR/AutoUpgrade.cpp

  Log Message:
  -----------
  [AutoUpgrade] Fix length check for intrinsic upgrade

The shortest intrinsics that can be upgraded via remangling have
8 characters (like "llvm.abs"). Make sure these go through the
upgrade code.

I think that currently this change is not observable from in-tree
callers of UpgradeIntrinsicFunction(), because callers do
redundant remangling checks. However, this issue shows up in
existing tests if those checks are removed (which I will do in
followup changes).




More information about the All-commits mailing list