[all-commits] [llvm/llvm-project] ba8ded: [lldb] Don't check environment default char signed...

[aeubanks via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ba8ded6820fa610c7460fe86cd1f41f1df4bcc6c
      https://github.com/llvm/llvm-project/commit/ba8ded6820fa610c7460fe86cd1f41f1df4bcc6c
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2022-10-20 (Thu, 20 Oct 2022)

  Changed paths:
    M lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp
    M lldb/test/API/commands/expression/char/TestExprsChar.py
    M lldb/test/API/commands/expression/char/main.cpp

  Log Message:
  -----------
  [lldb] Don't check environment default char signedness when creating clang type for "char"

With -f(un)signed-char, the die corresponding to "char" may be the opposite DW_ATE_(un)signed_char from the default platform signedness.
Ultimately we should determine whether a type is the unspecified signedness char by looking if its name is "char" (as opposed to "signed char"/"unsigned char") and not care about DW_ATE_(un)signed_char matching the platform default.

Fixes #23443

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D136011