[all-commits] [llvm/llvm-project] aa89ce: [win][compiler-rt] Make tests use lld-link instead...

aeubanks via All-commits all-commits at lists.llvm.org
Tue Oct 18 08:46:47 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: aa89ceab485cd8d5ff1e11dd67a479741ed1f6dd
      https://github.com/llvm/llvm-project/commit/aa89ceab485cd8d5ff1e11dd67a479741ed1f6dd
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2022-10-18 (Tue, 18 Oct 2022)

  Changed paths:
    M compiler-rt/test/asan/TestCases/Windows/dll_and_lib.cpp
    M compiler-rt/test/asan/TestCases/Windows/dll_large_function.cpp
    M compiler-rt/test/asan/TestCases/Windows/unsymbolized.cpp

  Log Message:
  -----------
  [win][compiler-rt] Make tests use lld-link instead of link

Git bash ships with a link.exe. We try to add git bash to the beginning
of PATH (see D84380). These tests end up executing the wrong link.exe.

As a workaround, use lld-link. Note that `REQUIRES: lld-available` tests currently aren't running, see D128567. I did manually verify that these tests pass with lld-link.

Reviewed By: rnk, hans

Differential Revision: https://reviews.llvm.org/D136108




More information about the All-commits mailing list