[all-commits] [llvm/llvm-project] 44027f: [mlir][GPU] Prevent adding duplicate async tokens

Krzysztof Drewniak via All-commits all-commits at lists.llvm.org
Tue Oct 18 08:37:33 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 44027f390854f3088bf85c5c4d8cf1405dd4bb4c
      https://github.com/llvm/llvm-project/commit/44027f390854f3088bf85c5c4d8cf1405dd4bb4c
  Author: Krzysztof Drewniak <Krzysztof.Drewniak at amd.com>
  Date:   2022-10-18 (Tue, 18 Oct 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/GPU/IR/GPUBase.td
    M mlir/include/mlir/Dialect/GPU/IR/GPUDialect.h
    M mlir/test/Dialect/GPU/async-region.mlir

  Log Message:
  -----------
  [mlir][GPU] Prevent adding duplicate async tokens

If, in the GPU async transformation, the operation being given an
async dependency already depended on the token in question, we
would add duplicate tokens, creating issues in GPU to LLVM lowering.

To resolve this issue, add a check to addAsyncDependency() to ensure
that duplicate tokens are not present in the token list.

(I'm open to a different approach here, this is just what I went with
initially)

Reviewed By: Mogball

Differential Revision: https://reviews.llvm.org/D136105




More information about the All-commits mailing list