[all-commits] [llvm/llvm-project] dfef31: [clang-tidy] Fix a false positive in readability-s...

Mon Oct 17 23:30:15 PDT 2022

  Branch: refs/heads/release/15.x
  Home:   https://github.com/llvm/llvm-project
  Commit: dfef316bb3d60edcb7a9f78abc62be78473458dc
      https://github.com/llvm/llvm-project/commit/dfef316bb3d60edcb7a9f78abc62be78473458dc
  Author: Nathan James <n.james93 at hotmail.co.uk>
  Date:   2022-10-18 (Tue, 18 Oct 2022)

  Changed paths:
    M clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp
    M clang-tools-extra/test/clang-tidy/checkers/readability/simplify-bool-expr-chained-conditional-return.cpp

  Log Message:
  -----------
  [clang-tidy] Fix a false positive in readability-simplify-boolean-expr

Reviewed By: LegalizeAdulthood

Differential Revision: https://reviews.llvm.org/D134590

(cherry picked from commit 8c783b8ec78ec857e446a89a35463baed8026f40)

  Commit: e3b0721b5b7371b2f13196997f9aa096d2179369
      https://github.com/llvm/llvm-project/commit/e3b0721b5b7371b2f13196997f9aa096d2179369
  Author: Michał Górny <mgorny at gentoo.org>
  Date:   2022-10-18 (Tue, 18 Oct 2022)

  Changed paths:
    M llvm/utils/lit/lit/llvm/config.py

  Log Message:
  -----------
  [llvm] [lit] Fix use_lld() to respect llvm_shlib_dir

Fix the use_lld() to use llvm_shlib_dir similarly to how use_clang()
does it.  This fixes use_lld() wrongly prepending llvm_libs_dir,
i.e. the directory with system-installed LLVM libraries before
the build directory of standalone build.  As a result, the shared
libraries from an earlier version of clang end up being used instead of
the newly built version when running the test suite prior to installing.

To reproduce the problem, build and install LLVM with dylibs first,
e.g.:

    cmake ../llvm -G Ninja -DCMAKE_BUILD_TYPE=MinSizeRel \
      -DCMAKE_INSTALL_PREFIX="${HOME}"/llvm-test \
      -DLLVM_BUILD_LLVM_DYLIB=ON -DLLVM_LINK_LLVM_DYLIB=ON \
      -DLLVM_INSTALL_UTILS=ON
    ninja install

Then build clang against that installation and run tests:

    export LD_LIBRARY_PATH=~/llvm-test/lib
    export PATh=~/llvm-test/bin:"${PATH}"
    cmake ../clang -G Ninja -DCMAKE_BUILD_TYPE=MinSizeRel \
      -DCMAKE_INSTALL_PREFIX="${HOME}"/llvm-test \
      -DCLANG_LINK_CLANG_DYLIB=ON -DLLVM_BUILD_TESTS=ON \
      -DLLVM_EXTERNAL_LIT="${PWD}"/bin/llvm-lit
    ninja check-clang

The tests will be run with LD_LIBRARY_PATH of:

    /home/${USER}/llvm-test/lib:/home/${USER}/llvm-project/build-clang/lib

As a result, installed libclang-cpp will take precedence over the one
from build dir.  With the patch, the correct path is used, i.e.:

    /home/${USER}/llvm-project/build-clang/lib:/home/${USER}/llvm-test/lib

Differential Revision: https://reviews.llvm.org/D135368

(cherry picked from commit a64ea173d7b152678780d5443407d1071277642b)

  Commit: 6fba7854a2f0b6b3899bb156c1a0c4ae35c96e24
      https://github.com/llvm/llvm-project/commit/6fba7854a2f0b6b3899bb156c1a0c4ae35c96e24
  Author: Michał Górny <mgorny at gentoo.org>
  Date:   2022-10-18 (Tue, 18 Oct 2022)

  Changed paths:
    M llvm/test/CMakeLists.txt

  Log Message:
  -----------
  [llvm] [test] Add missing canonicalization of LLVM_ENABLE_ZSTD

Add LLVM_ENABLE_ZSTD to llvm_canonicalize_cmake_booleans().  This is
needed to ensure that the substitutions in lit.site.cfg.py resolve
to correct Python booleans.

Differential Revision: https://reviews.llvm.org/D135357

(cherry picked from commit bc4bcbcfc820b324f680e8f260691c38052eedc9)

  Commit: b4840279846e1eea44c3dca575395a90c9d77ca0
      https://github.com/llvm/llvm-project/commit/b4840279846e1eea44c3dca575395a90c9d77ca0
  Author: Petr Hosek <phosek at google.com>
  Date:   2022-10-18 (Tue, 18 Oct 2022)

  Changed paths:
    A llvm/cmake/modules/Findzstd.cmake

  Log Message:
  -----------
  [CMake] Provide Findzstd module

This module is used to find the system zstd library. The imported
targets intentionally use the same name as the generate zstd config
CMake file so these can be used interchangeably.

Differential Revision: https://reviews.llvm.org/D134990

(cherry picked from commit 2d4fd0b6d5d5582ebb8b521d807104235d67aee4)

  Commit: 687250913265a0160c8fba2c0bd93ddd933ec9c2
      https://github.com/llvm/llvm-project/commit/687250913265a0160c8fba2c0bd93ddd933ec9c2
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2022-10-18 (Tue, 18 Oct 2022)

  Changed paths:
    M libcxx/include/__functional/function.h
    A libcxx/test/libcxx/utilities/function.objects/func.blocks.arc.pass.mm
    A libcxx/test/libcxx/utilities/function.objects/func.blocks.pass.cpp
    R libcxx/test/libcxx/utilities/function.objects/func.blocks.sh.cpp

  Log Message:
  -----------
  [libc++] Fix std::function's handling of blocks under Objc ARC

Previously, some uses of std::function with blocks would crash when ARC was enabled.

rdar://100907096

Differential Revision: https://reviews.llvm.org/D135706

(cherry picked from commit 0e4802bf45952b1120c52d4d1bf6bfa2800fd102)

  Commit: f6af95770615c2218084c82c62c10459feebbfbf
      https://github.com/llvm/llvm-project/commit/f6af95770615c2218084c82c62c10459feebbfbf
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2022-10-18 (Tue, 18 Oct 2022)

  Changed paths:
    M clang-tools-extra/clangd/TidyProvider.cpp

  Log Message:
  -----------
  [clangd] Block clang-tidy misc-const-correctness check

This check performs an extremely large amount of work (for each variable, it
runs very many full matcher-driven traversals of the whole scope the variable
is defined in).

When (inadvertently) enabled for Fuchsia, it regressed BuildAST times by >10x
(400ms -> 7s on my machine).

Differential Revision: https://reviews.llvm.org/D135829

(cherry picked from commit e78165f0ba1e2fbf72b36a36c8560645b69a168a)

  Commit: 4a2c05b05ed07f1f620e94f6524a8b4b2760a0b1
      https://github.com/llvm/llvm-project/commit/4a2c05b05ed07f1f620e94f6524a8b4b2760a0b1
  Author: David Green <david.green at arm.com>
  Date:   2022-10-18 (Tue, 18 Oct 2022)

  Changed paths:
    M llvm/lib/Target/ARM/ARMTargetTransformInfo.cpp
    M llvm/test/Analysis/CostModel/ARM/mve-cmp.ll

  Log Message:
  -----------
  [ARM] Fix for MVE i128 vector icmp costs.

We were hitting an assert as the legalied type needn't be a vector.

Fixes #58364

(cherry picked from commit de6dfbbb300e552efa1cd86a023063a39d408b06)

Compare: https://github.com/llvm/llvm-project/compare/d35bc70e8251...4a2c05b05ed0