[all-commits] [llvm/llvm-project] 45cadb: [AArch64][NFC]Refactor 'isBitfieldPositioningOp' s...

Mingming Liu via All-commits all-commits at lists.llvm.org
Mon Oct 17 08:09:54 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 45cadb4bd36b479dfc4daff451a6c924703ec7e0
      https://github.com/llvm/llvm-project/commit/45cadb4bd36b479dfc4daff451a6c924703ec7e0
  Author: Mingming Liu <mingmingl at google.com>
  Date:   2022-10-17 (Mon, 17 Oct 2022)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp

  Log Message:
  -----------
  [AArch64][NFC]Refactor 'isBitfieldPositioningOp' so that DAG nodes with different Opcode are handled with separate helper functions.

Using different helper functions for DAG nodes with different Opcode allows specialization.

- 'isBitfieldExtractOp' [1] shows how specialization based on Opcode could catch more patterns.
- The refactor paves the way (e.g., makes diff clearer) for enhancement in {D135844,D135850,D135852}

[1] https://github.com/llvm/llvm-project/blob/cbd8464595220b5ea76c70ac9965d84970c4b712/llvm/lib/Target/AArch64/AArch64ISelDAGToDAG.cpp#L2163-L2202

Differential Revision: https://reviews.llvm.org/D135843




More information about the All-commits mailing list