[all-commits] [llvm/llvm-project] 8d76fb: [VectorCombine] fix crashing on match of non-canon...

Sanjay Patel via All-commits all-commits at lists.llvm.org
Mon Oct 17 07:48:06 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8d76fbb5f0659bba47a7f38847550a2bc8bbf0c1
      https://github.com/llvm/llvm-project/commit/8d76fbb5f0659bba47a7f38847550a2bc8bbf0c1
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-10-17 (Mon, 17 Oct 2022)

  Changed paths:
    M llvm/lib/Transforms/Vectorize/VectorCombine.cpp
    M llvm/test/Transforms/VectorCombine/X86/extract-fneg-insert.ll

  Log Message:
  -----------
  [VectorCombine] fix crashing on match of non-canonical fneg

We can't assume that operand 0 is the negated operand because
the matcher handles "fsub -0.0, X" (and also +0.0 with FMF).

By capturing the extract within the match, we avoid the bug
and make the transform more robust (can't assume that this
pass will only see canonical IR).




More information about the All-commits mailing list