[all-commits] [llvm/llvm-project] 316123: [lld-macho][nfc] lld/Common's `demangle()` is redu...

[Jez Ng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 316123a2fce299ab86bceea67049b089efb11b9b
      https://github.com/llvm/llvm-project/commit/316123a2fce299ab86bceea67049b089efb11b9b
  Author: Jez Ng <jezng at fb.com>
  Date:   2022-10-14 (Fri, 14 Oct 2022)

  Changed paths:
    M lld/MachO/Symbols.cpp

  Log Message:
  -----------
  [lld-macho][nfc] lld/Common's `demangle()` is redundant for Mach-O

The only thing that the Common implementation does is a check for
`config->demangle`, but {D135189} added that check to
`maybeDemangleSymbol`, so there's no need to go through `Common`...

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D135942


  Commit: 32647c8f53a6558833acca95dc241e9e1132ecce
      https://github.com/llvm/llvm-project/commit/32647c8f53a6558833acca95dc241e9e1132ecce
  Author: Jez Ng <jezng at fb.com>
  Date:   2022-10-14 (Fri, 14 Oct 2022)

  Changed paths:
    M lld/COFF/Symbols.cpp
    M lld/ELF/SymbolTable.cpp
    M lld/ELF/Symbols.cpp
    M lld/MachO/SymbolTable.cpp
    M lld/include/lld/Common/Strings.h
    M lld/wasm/Symbols.cpp

  Log Message:
  -----------
  [lld][nfc] Remove lld::demangle() (partial revert of D116279)

{D116279}, in addition to adding support for other demanglers, also
factored out some of the demangling logic. However, I don't think the
abstraction really carries its weight -- after {D135942}, only the ELF
and WASM backends call it with anything other than a non-constant
`shouldDemangle` argument. The COFF and Mach-O backends were already
doing the should-demangle check before calling `demangle()`.

Reviewed By: MaskRay, #lld-macho

Differential Revision: https://reviews.llvm.org/D135943


Compare: https://github.com/llvm/llvm-project/compare/1cfae76ed91a...32647c8f53a6