[all-commits] [llvm/llvm-project] c3bc72: llvm-reduce: Improve delta pass flag handling

Matt Arsenault via All-commits all-commits at lists.llvm.org
Wed Oct 12 17:25:41 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c3bc72ccb23eb13aa6efba81adf68a0518eebc52
      https://github.com/llvm/llvm-project/commit/c3bc72ccb23eb13aa6efba81adf68a0518eebc52
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    A llvm/test/tools/llvm-reduce/skip-delta-passes.ll
    M llvm/tools/llvm-reduce/DeltaManager.cpp

  Log Message:
  -----------
  llvm-reduce: Improve delta pass flag handling

Verify all the requested passes exist before trying to run any.
For long reductions, it was really annoying for it to get halfway through
and then I come back later to an incomplete reduction.

Also add a new skip-delta-passes flag. Most of the time I want to opt out
of specific reductions, rather than run a select few.


  Commit: c23ac22f0ed9b76f127794534b3dfd5557389aed
      https://github.com/llvm/llvm-project/commit/c23ac22f0ed9b76f127794534b3dfd5557389aed
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M llvm/tools/llvm-reduce/ReducerWorkItem.cpp
    M llvm/tools/llvm-reduce/ReducerWorkItem.h

  Log Message:
  -----------
  llvm-reduce: Don't write out IR to score IR complexity

In a testcase I'm working on, the old write out and count IR lines
was taking about 200-300ms per iteration. This drops it out of the
profile.

This doesn't account for everything, but it doesn't seem to matter.
We should probably try to account for metadata and constantexpr tree
depths.


  Commit: 575eed3dace3c9c741cfc47be02ea1dee4b0402b
      https://github.com/llvm/llvm-project/commit/575eed3dace3c9c741cfc47be02ea1dee4b0402b
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp
    M llvm/test/CodeGen/AMDGPU/mai-hazards.mir

  Log Message:
  -----------
  AMDGPU: Fix hazard with v_accvgpr_write_b32 and inline asm VGPR defs

If inline asm has a VGPR def, it must have come from a VGPR write
somewhere inside the asm. This should be further extended to all
read after write hazards.


  Commit: 838fd611b79e3514eead5dd724140df046172ef1
      https://github.com/llvm/llvm-project/commit/838fd611b79e3514eead5dd724140df046172ef1
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
    M llvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-mul24.ll

  Log Message:
  -----------
  AMDGPU: Fix assertion on <1 x i16> vectors

Fixes issue 58331.


Compare: https://github.com/llvm/llvm-project/compare/0ec3ac9b7fbd...838fd611b79e


More information about the All-commits mailing list