[all-commits] [llvm/llvm-project] 39db49: [LeakSanitizer] Capture calling thread SP early to...

Vitaly Buka via All-commits all-commits at lists.llvm.org
Wed Oct 12 16:47:01 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 39db491957dcf095936d81bed89c2b4edae2a1e7
      https://github.com/llvm/llvm-project/commit/39db491957dcf095936d81bed89c2b4edae2a1e7
  Author: Wiktor Garbacz <wiktorg at google.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M compiler-rt/lib/lsan/lsan_common.cpp
    M compiler-rt/lib/lsan/lsan_common.h

  Log Message:
  -----------
  [LeakSanitizer] Capture calling thread SP early to avoid false negatives.

As shown in https://github.com/llvm/llvm-project/issues/42932 dead
pointers might be overlapped by a new stack frame inside CheckForLeaks,
which does not use bytes with pointers. This leads to false negatives.

It's not a full solution for the problem as it does not solve
"overlapping" new/old frames for frames below the CheckForLeaks and in
other threads. It should improve leaks found in direct callers of
__lsan_do_leak_check.

Differential Revision: https://reviews.llvm.org/D130237


  Commit: 74fea6bffeb1724e761ece6b74561fbe4efc8d6d
      https://github.com/llvm/llvm-project/commit/74fea6bffeb1724e761ece6b74561fbe4efc8d6d
  Author: Vitaly Buka <vitalybuka at google.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M openmp/tools/archer/tests/races/critical-unrelated.c

  Log Message:
  -----------
  [test][openmp] Relax check for tsan reports count

I see 2 reports time to time.


Compare: https://github.com/llvm/llvm-project/compare/24989646a521...74fea6bffeb1


More information about the All-commits mailing list