[all-commits] [llvm/llvm-project] 137989: [libc++] Replace some _LIBCPP_HIDDEN with _LIBCPP...

David Tenty via All-commits all-commits at lists.llvm.org
Wed Oct 12 13:47:15 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1379899518b02496a2b4a536fc9095b5456e7b7e
      https://github.com/llvm/llvm-project/commit/1379899518b02496a2b4a536fc9095b5456e7b7e
  Author: David Tenty <daltenty at ibm.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M libcxx/include/__algorithm/sort.h
    M libcxx/include/__iterator/ostreambuf_iterator.h
    M libcxx/include/locale

  Log Message:
  -----------
   [libc++] Replace some _LIBCPP_HIDDEN with _LIBCPP_HIDE_FROM_ABI

These "implementation detail" function templates were already
hidden and have no specializations in the dylib, so they seem like they can safely
use _LIBCPP_HIDE_FROM_ABI instead and have the abi tags applied as well.

Seems some of these got over looked (e.g. D129823) in various places, and they
won't be flagged by the new checks added in D129968, as they were
already hidden.

Reviewed by: ldionne

Differential Revision: https://reviews.llvm.org/D135504




More information about the All-commits mailing list