[all-commits] [llvm/llvm-project] bc032c: [InstCombine] add tests for div with shl operands; ...

Sanjay Patel via All-commits all-commits at lists.llvm.org
Wed Oct 12 06:26:49 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bc032c7f53463fe1e0b2d3eab6c72299a184b6c1
      https://github.com/llvm/llvm-project/commit/bc032c7f53463fe1e0b2d3eab6c72299a184b6c1
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M llvm/test/Transforms/InstCombine/div-shift.ll

  Log Message:
  -----------
  [InstCombine] add tests for div with shl operands; NFC


  Commit: d117ee25b8d19dd63deecaed4759be032708dd90
      https://github.com/llvm/llvm-project/commit/d117ee25b8d19dd63deecaed4759be032708dd90
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp

  Log Message:
  -----------
  [InstCombine] add helper function for div+shl folds; NFC

There are at least 2 similar patterns that could be added here,
and the existing fold can be improved because it fails to
propagate "exact".


  Commit: 2639caf5608af0b0273a193e0f45f8f965daa21e
      https://github.com/llvm/llvm-project/commit/2639caf5608af0b0273a193e0f45f8f965daa21e
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M llvm/test/Transforms/InstCombine/div-shift.ll

  Log Message:
  -----------
  [InstCombine] add "exact" to div tests to show missing propagation; NFC


  Commit: fe97f95036674692dd85939c867c4312b73df88f
      https://github.com/llvm/llvm-project/commit/fe97f95036674692dd85939c867c4312b73df88f
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
    M llvm/test/Transforms/InstCombine/div-shift.ll

  Log Message:
  -----------
  [InstCombine] propagate "exact" through folds of div

These folds were added recently with:
6b869be8100d
8da2fa856f1b
...but they didn't account for the "exact" attribute,
and that can be safely propagated:
https://alive2.llvm.org/ce/z/F_WhnR
https://alive2.llvm.org/ce/z/ft9Cgr


Compare: https://github.com/llvm/llvm-project/compare/7883900c04fc...fe97f9503667


More information about the All-commits mailing list