[all-commits] [llvm/llvm-project] 6faa34: [LLDB] Pass const RegisterInfo& to RegisterValue::...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6faa345da9d747c65c4d901c4ef26dfedf95da45
      https://github.com/llvm/llvm-project/commit/6faa345da9d747c65c4d901c4ef26dfedf95da45
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2022-10-12 (Wed, 12 Oct 2022)

  Changed paths:
    M lldb/include/lldb/Utility/RegisterValue.h
    M lldb/source/Core/ValueObjectRegister.cpp
    M lldb/source/Core/ValueObjectVariable.cpp
    M lldb/source/Plugins/ABI/AArch64/ABIMacOSX_arm64.cpp
    M lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp
    M lldb/source/Plugins/Process/Utility/RegisterContextMemory.cpp
    M lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
    M lldb/source/Utility/RegisterValue.cpp

  Log Message:
  -----------
  [LLDB] Pass const RegisterInfo& to RegisterValue::SetValueFromData

Familiar story, callers are either checking upfront that the pointer
wasn't null or not checking at all. SetValueFromData itself didn't
check either.

So make the parameter a ref and fixup the few places where a nullptr
check seems needed.

Depends on D135668

Reviewed By: clayborg

Differential Revision: https://reviews.llvm.org/D135670