[all-commits] [llvm/llvm-project] 060b25: [clang][deps] Remove more codegen options

[Jan Svoboda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 060b25346b95cc161d21418f31c333f9a115d77e
      https://github.com/llvm/llvm-project/commit/060b25346b95cc161d21418f31c333f9a115d77e
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2022-10-11 (Tue, 11 Oct 2022)

  Changed paths:
    M clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp
    M clang/test/ClangScanDeps/Inputs/removed-args/cdb.json.template
    M clang/test/ClangScanDeps/removed-args.c

  Log Message:
  -----------
  [clang][deps] Remove more codegen options

Codegen options are typically unused by modules. Reset some of them to increase sharing between TUs with different flags.

Reviewed By: Bigcheese

Differential Revision: https://reviews.llvm.org/D135720


  Commit: c1c72302fe4553a39be37b5c310d046975e55019
      https://github.com/llvm/llvm-project/commit/c1c72302fe4553a39be37b5c310d046975e55019
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2022-10-11 (Tue, 11 Oct 2022)

  Changed paths:
    M clang/lib/Frontend/FrontendAction.cpp
    A clang/test/ClangScanDeps/modules-implementation-module-map.c

  Log Message:
  -----------
  [clang][deps] Prevent emitting diagnostics outside of source file

The dependency scanner needs to report the module map file describing the module whose implementation is being compiled (see D134222). However, calling `Preprocessor::getCurrentModuleImplementation()` in the scanner might cause a diagnostic during module map parsing and emitting a diagnostic without being "in" a source file is illegal (e.g. in `TextDiagnosticPrinter`). This patch ensures the module map parse is triggered while the compiler is still "in" a source file, avoiding the failure case.

Reviewed By: Bigcheese

Differential Revision: https://reviews.llvm.org/D135637


Compare: https://github.com/llvm/llvm-project/compare/adf36ea32891...c1c72302fe45