[all-commits] [llvm/llvm-project] b8e717: Revert "[gn build] Don't set LLVM_UNREACHABLE_OPTI...

[aeubanks via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b8e71766c835603b6353827dc54939e1740f4867
      https://github.com/llvm/llvm-project/commit/b8e71766c835603b6353827dc54939e1740f4867
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2022-10-10 (Mon, 10 Oct 2022)

  Changed paths:
    M llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn

  Log Message:
  -----------
  Revert "[gn build] Don't set LLVM_UNREACHABLE_OPTIMIZE when llvm_enable_assertions"

This reverts commit 0f19c603423e28ab663c1fdff2048c555abe5f6d.

This didn't actually do anything. llvm_unreachable() under `#ifndef NDEBUG` is always supposed to report an error regardless of LLVM_UNREACHABLE_OPTIMIZE. I can't reproduce the issue I was originally seeing with this reverted, not sure what was happening back then, manually verified by messing around with various binaries/configurations.