[all-commits] [llvm/llvm-project] e5fd50: [NFCI] More TypeCategoryImpl refactoring.

[Jorge Gorbe Moya via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e5fd507f9b6f774c83c7b061fa77c906c882935b
      https://github.com/llvm/llvm-project/commit/e5fd507f9b6f774c83c7b061fa77c906c882935b
  Author: Jorge Gorbe Moya <jgorbe at google.com>
  Date:   2022-10-10 (Mon, 10 Oct 2022)

  Changed paths:
    M lldb/include/lldb/DataFormatters/TypeCategory.h
    M lldb/source/Commands/CommandObjectType.cpp
    M lldb/source/DataFormatters/FormatManager.cpp
    M lldb/source/DataFormatters/FormattersHelpers.cpp
    M lldb/source/DataFormatters/TypeCategory.cpp
    M lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
    M lldb/source/Plugins/Language/ObjC/ObjCLanguage.cpp

  Log Message:
  -----------
  [NFCI] More TypeCategoryImpl refactoring.

The main aim of this patch is to delete the remaining instances of code
reaching into the internals of `TypeCategoryImpl`. I made the following
changes:

- Add some more methods to `TieredFormatterContainer` and
  `TypeCategoryImpl` to expose functionality that is implemented in
  `FormattersContainer`.

- Add new overloads of `TypeCategoryImpl::AddTypeXXX` to make it easier
  to add formatters to categories without reaching into the internal
  `FormattersContainer` objects.

- Remove the `GetTypeXXXContainer` and `GetRegexTypeXXXContainer`
  accessors from `TypeCategoryImpl` and update all call sites to use the
  new methods instead.

Differential Revision: https://reviews.llvm.org/D135399