[all-commits] [llvm/llvm-project] b62f5f: [Clang][Sema] Narrow inline namespace filtration f...

Troy Johnson via All-commits all-commits at lists.llvm.org
Mon Oct 10 08:35:55 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b62f5fb64edec7f5917a233bf0a9a30e1e4b70f0
      https://github.com/llvm/llvm-project/commit/b62f5fb64edec7f5917a233bf0a9a30e1e4b70f0
  Author: Troy Johnson <troyj at meta.com>
  Date:   2022-10-10 (Mon, 10 Oct 2022)

  Changed paths:
    M clang/lib/Sema/SemaTemplateInstantiateDecl.cpp

  Log Message:
  -----------
  [Clang][Sema] Narrow inline namespace filtration for unqualified friend declarations

rG04ba1856 introduced a call to FilterLookupForScope that is expensive
for very large translation units where it was observed to cause a 6%
compile time degradation. As the comment states, the only effect is to
"remove declarations found in inline namespaces for friend declarations
with unqualified names." This change limits the call to that scenario.
The test that was added by rG04ba1856 continues to pass, but the
observed degradation is cut in half.

Differential Revision: https://reviews.llvm.org/D135370




More information about the All-commits mailing list