[all-commits] [llvm/llvm-project] deb82d: Revert "[PGO] Make emitted symbols hidden"

Alex Brachet via All-commits all-commits at lists.llvm.org
Mon Oct 10 07:39:43 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: deb82d4a20150b4c983ed02adcfd2ca84691b74b
      https://github.com/llvm/llvm-project/commit/deb82d4a20150b4c983ed02adcfd2ca84691b74b
  Author: Alex Brachet <abrachet at google.com>
  Date:   2022-10-10 (Mon, 10 Oct 2022)

  Changed paths:
    M llvm/lib/ProfileData/InstrProf.cpp
    M llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
    M llvm/test/Transforms/PGOProfile/branch1.ll
    M llvm/test/Transforms/PGOProfile/branch2.ll
    M llvm/test/Transforms/PGOProfile/comdat_internal.ll
    M llvm/test/Transforms/PGOProfile/criticaledge.ll
    R llvm/test/Transforms/PGOProfile/filename.ll
    M llvm/test/Transforms/PGOProfile/instr_entry_bb.ll
    M llvm/test/Transforms/PGOProfile/landingpad.ll
    M llvm/test/Transforms/PGOProfile/loop1.ll
    M llvm/test/Transforms/PGOProfile/loop2.ll
    M llvm/test/Transforms/PGOProfile/lto_cspgo_gen.ll
    M llvm/test/Transforms/PGOProfile/single_bb.ll
    M llvm/test/Transforms/PGOProfile/switch.ll
    M llvm/test/Transforms/PGOProfile/thinlto_cspgo_gen.ll

  Log Message:
  -----------
  Revert "[PGO] Make emitted symbols hidden"

This reverts commit 4ea1a647ff0973c683dd71fec77e6fe7f6dfd2ca.

This breaks on Darwin which tries to export these symbols
https://github.com/llvm/llvm-project/blob/ebb258d3b0785f6dcc65e1f277d0690891ddc94d/clang/lib/Driver/ToolChains/Darwin.cpp#L1363

I'll try to reland which that removed and approval from
Apple folks.




More information about the All-commits mailing list